Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-703] Restructure avatar creator samples #185

Merged
merged 4 commits into from
Dec 7, 2023
Merged

[SDK-703] Restructure avatar creator samples #185

merged 4 commits into from
Dec 7, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Dec 7, 2023 •
edited
Loading

SDK-703

Description

  • Restructure of samples folder
    • SimpleAvatarCreator - Made using new elements
    • LegacyAvatarCreator - Legacy creator made from older code and prefabs

How to Test

  • Run and test avatar creator samples

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Dec 7, 2023
@rYuuk rYuuk requested a review from a team as a code owner December 7, 2023 02:15
HarrisonHough
HarrisonHough requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only thing is I think you need to update the scene path for the integration guide "open sample scene" button

image

@rYuuk rYuuk requested a review from HarrisonHough December 7, 2023 09:23
HarrisonHough
HarrisonHough approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@rYuuk rYuuk merged commit c976f09 into develop Dec 7, 2023
@rYuuk rYuuk deleted the feature/folder-restructure-avatar-creator-samples branch December 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough