Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add source param to web avatar creator #186

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat: add source param to web avatar creator #186

merged 3 commits into from
Dec 13, 2023

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Dec 11, 2023 •
edited by jira bot
Loading

SDK-677

Description

  • Add source parameter to the URLs

How to Test

  • Check, that the event is sent to amplitude with the given source, when opening the avatar creator

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rk132 rk132 requested a review from a team as a code owner December 11, 2023 11:33
rYuuk
rYuuk approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

@rk132 rk132 merged commit dafbb07 into develop Dec 13, 2023
@rk132 rk132 deleted the feature/add-source-param-to-web-avatar-creator branch December 13, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rYuuk rYuuk rYuuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @rYuuk