Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow preloading selectionElements #243

Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat: allow preloading selectionElements #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions Runtime/AvatarCreator/Scripts/UI/Elements/SelectionElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,22 @@ public abstract class SelectionElement : MonoBehaviour
[SerializeField] private SelectionButton buttonElementPrefab;
[SerializeField] private GameObject selectedIconPrefab;
[SerializeField] private Transform buttonContainer;
private GameObject selectedIcon;

private GameObject _selectedIcon;
private GameObject selectedIcon
{
get
{
if (_selectedIcon)
{
return _selectedIcon;
}
_selectedIcon = Instantiate(selectedIconPrefab, buttonContainer);
selectedIcon.SetActive(false);
return _selectedIcon;
}
}


[Space(5)]
[Header("Events")]
Expand All @@ -28,12 +43,6 @@ public abstract class SelectionElement : MonoBehaviour

protected Transform ButtonContainer => buttonContainer;

private void Start()
{
selectedIcon = Instantiate(selectedIconPrefab, buttonContainer);
selectedIcon.SetActive(false);
}

/// <summary>
/// Creates button elements for each asset in the provided array.
/// This function is generic and can work with any asset type that implements the IAssetData interface.
Expand Down
Loading