Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-800] Add body shapes #252

Merged
merged 3 commits into from
Mar 28, 2024
Merged

[SDK-800] Add body shapes #252

merged 3 commits into from
Mar 28, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Mar 26, 2024 •
edited by jira bot
Loading

SDK-800

image

Description

  • Added body shapes to the SDK
  • Updated Elements scene to have the bodyshapes

How to Test

  • Check, that avatar changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rk132 rk132 requested a review from a team as a code owner March 26, 2024 14:36
HarrisonHough
HarrisonHough requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and suggestions.
But otherwise it is working well

Runtime/Core/Scripts/Data/Enums.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/SimpleAvatarCreator.cs Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/ElementSectionManager.cs Outdated Show resolved Hide resolved
Runtime/AvatarCreator/Scripts/UI/Elements/BodyShapeSelectionElement.cs Show resolved Hide resolved
@HarrisonHough HarrisonHough self-requested a review March 27, 2024 08:57
@rk132 rk132 merged commit ca018f9 into develop Mar 28, 2024
@rk132 rk132 deleted the feature/add-body-shapes branch March 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough