Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-926] feat: added optional parameter to filter meshes #267

Merged
merged 2 commits into from
May 2, 2024

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented May 2, 2024

SDK-926

Description

  • This improves the get mesh renderer function to optionally filter for null skin meshes. This is useful when you are using the AvatarTemplate prefab which has all possible skinnedmeshrenders (for mesh transfer purposes). Old functionality would return the first head mesh out of these three "Renderer_Head", "Renderer_Avatar", "Renderer_Head_Custom" regardless of whether they were empty or not which causes the eye blinking not to work.
  • I also added an extra UpdateHeadMesh() method which would be useful if you want to find and set the head mesh from code, the usecase would be if you are loading avatars with different configurations EG Texture atlas and non texture atlassed using the mesh transfer technique

How to Test

  • 1 way to test would be to simply drag the RPM_Template_Avatar_XR prefab into the scene and add the EyeAnimationHandler and run to see if the blinking works.

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

Sorry, something went wrong.

@HarrisonHough HarrisonHough requested a review from a team as a code owner May 2, 2024 09:48
@HarrisonHough HarrisonHough merged commit 2427bf9 into develop May 2, 2024
@HarrisonHough HarrisonHough deleted the feature/eye-animation-handler-fix branch May 2, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants