Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gender option to template selection element #273

Merged
merged 2 commits into from
May 15, 2024
Merged

feat: add gender option to template selection element #273

merged 2 commits into from
May 15, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented May 14, 2024 •
edited by jira bot
Loading

SDK-797

Description

  • Add option to filter template elements by gender

How to Test

  • Check, that filtering works for gender

@rk132 rk132 requested a review from a team as a code owner May 14, 2024 13:56
HarrisonHough
HarrisonHough approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers but I think there might be a more practical way to do the gender filtering. Happy to discuss if you want.

Runtime/AvatarCreator/Scripts/AvatarTemplateFetcher.cs Outdated Show resolved Hide resolved
@rk132 rk132 merged commit c658f70 into develop May 15, 2024
@rk132 rk132 deleted the feature/add-gender-option-to-template-selection-element branch May 15, 2024 09:28
HarrisonHough
HarrisonHough approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good just an idea slightly different approach.

Runtime/AvatarCreator/Scripts/UI/Elements/TemplateSelectionElement.cs Show resolved Hide resolved
Runtime/AvatarCreator/Scripts/UI/Elements/TemplateSelectionElement.cs Show resolved Hide resolved
@rk132 rk132 restored the feature/add-gender-option-to-template-selection-element branch May 15, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough