Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-806] - Add user auth #276

Merged
merged 5 commits into from
May 21, 2024
Merged

[SDK-806] - Add user auth #276

merged 5 commits into from
May 21, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented May 20, 2024 •
edited by jira bot
Loading

SDK-806

Description

  • Fix an issue, where when the avatar is deleted, it is not replaced with a new draft avatar
  • save user auth state

How to Test

  • Check, that when you start and stop the creator, the state is saved

@rk132 rk132 requested a review from a team as a code owner May 20, 2024 12:42
@rk132 rk132 requested a review from HarrisonHough May 20, 2024 12:54
HarrisonHough
HarrisonHough requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things in comments. But otherwise all good

Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/PanelManager.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/PanelManager.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/PanelManager.cs Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/UserAccountManager.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/UserAccountManager.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/UserAccountManager.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/SimpleAvatarCreator.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorElements/Scripts/SimpleAvatarCreator.cs Outdated Show resolved Hide resolved
HarrisonHough
HarrisonHough approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go, nice work

@rk132 rk132 merged commit 12c5c99 into develop May 21, 2024
@rk132 rk132 deleted the feature/add-user-auth branch May 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough