Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate avatar id with requests #278

Merged
merged 1 commit into from
May 22, 2024
Merged

feat: validate avatar id with requests #278

merged 1 commit into from
May 22, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented May 21, 2024 •
edited by jira bot
Loading

SDK-778

Description

  • Throw error before request, if the avatar ID is invalid

How to Test

  • Try making a request with ID, that is null or empty and see, that it fails with an error

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rk132 rk132 requested a review from a team as a code owner May 21, 2024 08:59
@HarrisonHough HarrisonHough self-requested a review May 22, 2024 10:53
HarrisonHough
HarrisonHough approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, cool stuff!

@rk132 rk132 merged commit 774c87d into develop May 22, 2024
6 checks passed
@rk132 rk132 deleted the feature/throw-error-for-invalid-avatar-id branch May 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough