Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-984] - move bodytype to settings #290

Merged
merged 8 commits into from
Jun 14, 2024
Merged

[SDK-984] - move bodytype to settings #290

merged 8 commits into from
Jun 14, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Jun 11, 2024 •
edited
Loading

SDK-984

image

Description

  • Bodytype is moved to the settings page and removed from configurations. This means, that users don't need to set it manually everywhere.

@rk132 rk132 requested a review from a team as a code owner June 11, 2024 07:51
HarrisonHough
HarrisonHough approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff in comments.
Overall looks good, it's a lot of changes but I like that it reduces the number of parameters required in a lot of functions.

Runtime/AvatarCreator/Scripts/WebRequests/Responses/GetUserAvatarsResponse.cs Outdated Show resolved Hide resolved
Samples~/AvatarCreatorSamples/AvatarCreatorWizard/Scripts/UI/CategoryUICreator.cs Outdated Show resolved Hide resolved
@rk132 rk132 merged commit dcf3ed6 into develop Jun 14, 2024
@rk132 rk132 deleted the feature/move-bodytype-to-settings branch June 14, 2024 07:41
@HarrisonHough HarrisonHough mentioned this pull request Jun 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough