Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRV-1434 webgl voice handler outofbounds #322

Merged
merged 3 commits into from
Oct 7, 2024
Merged

SRV-1434 webgl voice handler outofbounds #322

merged 3 commits into from
Oct 7, 2024

Conversation

arturtreiberg
Copy link
Contributor

@arturtreiberg arturtreiberg commented Oct 7, 2024 •
edited by jira bot
Loading

SRV-1434

Description

  • This changes adds additional checks that would limit reaching memory access out of bounds on WebGL error.

How to Test

  • Create new project, import example scene
  • add VoiceHandler component
  • set build target to webGL and run the built application

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@arturtreiberg arturtreiberg requested a review from a team as a code owner October 7, 2024 07:24
@arturtreiberg arturtreiberg changed the base branch from main to develop October 7, 2024 07:25
HarrisonHough
HarrisonHough approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, nice work!

Runtime/Core/Scripts/Animation/VoiceHandler.cs Outdated Show resolved Hide resolved
@arturtreiberg arturtreiberg merged commit 8335560 into develop Oct 7, 2024
@arturtreiberg arturtreiberg deleted the bugfix/webgl-voice-handler_outofbounds branch October 7, 2024 09:29
@HarrisonHough HarrisonHough mentioned this pull request Oct 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturtreiberg @HarrisonHough