Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when disable command is preceded by unicode character #5976

Merged
merged 4 commits into from
Mar 15, 2025

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #5945.

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 21, 2025

18 Messages
📖 Building this branch resulted in a binary size of 29603.41 KiB vs 29602.9 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.95 s vs 0.93 s on main (2% slower).
📖 Linting Alamofire with this PR took 1.27 s vs 1.28 s on main (0% faster).
📖 Linting Brave with this PR took 8.59 s vs 8.57 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 5.78 s vs 5.8 s on main (0% faster).
📖 Linting Firefox with this PR took 11.93 s vs 12.03 s on main (0% faster).
📖 Linting Kickstarter with this PR took 10.17 s vs 10.11 s on main (0% slower).
📖 Linting Moya with this PR took 0.52 s vs 0.53 s on main (1% faster).
📖 Linting NetNewsWire with this PR took 2.89 s vs 2.89 s on main (0% slower).
📖 Linting Nimble with this PR took 0.78 s vs 0.78 s on main (0% slower).
📖 Linting PocketCasts with this PR took 8.85 s vs 8.88 s on main (0% faster).
📖 Linting Quick with this PR took 0.43 s vs 0.43 s on main (0% slower).
📖 Linting Realm with this PR took 4.54 s vs 4.56 s on main (0% faster).
📖 Linting Sourcery with this PR took 2.33 s vs 2.35 s on main (0% faster).
📖 Linting Swift with this PR took 4.77 s vs 4.75 s on main (0% slower).
📖 Linting VLC with this PR took 1.32 s vs 1.32 s on main (0% slower).
📖 Linting Wire with this PR took 18.84 s vs 18.81 s on main (0% slower).
📖 Linting WordPress with this PR took 11.33 s vs 11.27 s on main (0% slower).

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the unicode-before-command branch from 5905446 to db786b3 Compare January 22, 2025 20:13
@SimplyDanny SimplyDanny force-pushed the unicode-before-command branch from db786b3 to f486bb3 Compare January 26, 2025 15:49
@SimplyDanny SimplyDanny force-pushed the unicode-before-command branch from 205f358 to 5f854a6 Compare March 9, 2025 10:57
@SimplyDanny SimplyDanny force-pushed the unicode-before-command branch from 5f854a6 to 471f68e Compare March 15, 2025 21:42
@SimplyDanny SimplyDanny merged commit 22e0f42 into realm:main Mar 15, 2025
20 checks passed
@SimplyDanny SimplyDanny deleted the unicode-before-command branch March 15, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with swiftlint directive after emoji with skin tone
4 participants