Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription state and tests #1672

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add subscription state and tests #1672

merged 1 commit into from
Mar 4, 2024

Conversation

clementetb
Copy link
Contributor

Fixes #1671

@clementetb clementetb self-assigned this Feb 29, 2024
@cla-bot cla-bot bot added the cla: yes label Feb 29, 2024
rorbech
rorbech approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... when CI is green

@clementetb clementetb merged commit 44753f1 into main Mar 4, 2024
55 checks passed
@clementetb clementetb deleted the ct/add-missing-subscription-state branch March 4, 2024 11:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rorbech rorbech rorbech approved these changes

@dianaafanador3 dianaafanador3 Awaiting requested review from dianaafanador3

Assignees

@clementetb clementetb

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException while waiting for the synchronization of a subscription.
2 participants
@clementetb @rorbech