Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin problem matchers #1775

Merged
merged 75 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
27c4c39
Add kotlin compiler matcher
clementetb Jun 4, 2024
ff367e3
Update workflow
clementetb Jun 4, 2024
03a14ee
Update matchers
clementetb Jun 4, 2024
2acb2bd
deduplicate owners
clementetb Jun 4, 2024
445f7ea
Bump actions versions
clementetb Jun 5, 2024
1a14a3e
Bump checkout
clementetb Jun 5, 2024
e106e6c
bum upload-artifact
clementetb Jun 5, 2024
1524934
bump gradle/gradle-build-action@v2
clementetb Jun 5, 2024
8149117
Update download artifact
clementetb Jun 5, 2024
2217f69
Fix uses
clementetb Jun 5, 2024
f1c8153
bump actions cmake
clementetb Jun 5, 2024
a119039
Bum setup java
clementetb Jun 5, 2024
002f749
Update cache action
clementetb Jun 5, 2024
f128b5f
Bump checkstyle
clementetb Jun 5, 2024
5f4d4d3
Use lookup-only
clementetb Jun 5, 2024
03c8ec9
Remove JesseTG/rm
clementetb Jun 5, 2024
361f588
Disable Actions
clementetb Jun 5, 2024
1c925c5
Remove check cache dependency
clementetb Jun 5, 2024
1bd9705
Disable other jobs
clementetb Jun 5, 2024
9d40252
Remove requirement
clementetb Jun 5, 2024
6e05d69
Use cache on jni stubs
clementetb Jun 5, 2024
6786245
Update steps
clementetb Jun 5, 2024
7fd7931
testing output
clementetb Jun 5, 2024
c50bc67
other test
clementetb Jun 5, 2024
b8bade2
job status
clementetb Jun 5, 2024
edfa0dc
another step
clementetb Jun 5, 2024
a73076f
add missing requirement
clementetb Jun 5, 2024
a2e2070
testing
clementetb Jun 5, 2024
ed90277
Split cache jobs
clementetb Jun 5, 2024
6997794
restore pr.yml
clementetb Jun 5, 2024
c81f51d
add matcher
clementetb Jun 5, 2024
90d211f
testing
clementetb Jun 5, 2024
aa32dbe
fix inputs
clementetb Jun 5, 2024
c42d7bb
bum download artifacts
clementetb Jun 5, 2024
39867bf
fix name
clementetb Jun 6, 2024
671b16b
test
clementetb Jun 6, 2024
d3afc83
more testing
clementetb Jun 6, 2024
3e843c4
more testing
clementetb Jun 6, 2024
302de3f
more testing
clementetb Jun 6, 2024
8909760
Testing
clementetb Jun 6, 2024
fea70a7
test
clementetb Jun 6, 2024
ade1671
test
clementetb Jun 6, 2024
96c6bbe
test
clementetb Jun 6, 2024
9c6b365
test
clementetb Jun 6, 2024
3c8e5dd
test
clementetb Jun 6, 2024
e663d5c
testing
clementetb Jun 6, 2024
0e896b3
some updates
clementetb Jun 6, 2024
0588b63
bump version
clementetb Jun 6, 2024
47c7e21
bump ccache action
clementetb Jun 6, 2024
9502fe4
bump setup ninja
clementetb Jun 6, 2024
7bdb4d5
upgrade aws-credentials
clementetb Jun 6, 2024
7d8ef23
introduce linting issue
clementetb Jun 6, 2024
0016ab8
Add ktlint matcher
clementetb Jun 6, 2024
f9c4933
upload reports
clementetb Jun 6, 2024
935eff1
catch detekt errors
clementetb Jun 6, 2024
d24d467
Fix regex
clementetb Jun 6, 2024
2dfb9a5
Remove code detection
clementetb Jun 6, 2024
914c4ab
update kotlin matcher
clementetb Jun 7, 2024
58d148c
Register kotlin matchers
clementetb Jun 7, 2024
984a41c
test
clementetb Jun 7, 2024
d2f17b1
test
clementetb Jun 7, 2024
d203cfe
test
clementetb Jun 7, 2024
08cad82
test
clementetb Jun 7, 2024
9f7d993
test
clementetb Jun 7, 2024
a1a5911
test
clementetb Jun 7, 2024
da305fe
test
clementetb Jun 7, 2024
9539e10
test
clementetb Jun 7, 2024
1790364
revert forcing warning
clementetb Jun 7, 2024
c1fe0fa
Add matchers to build steps
clementetb Jun 7, 2024
0c7d622
test
clementetb Jun 7, 2024
08bbc8a
test
clementetb Jun 7, 2024
9f03eb7
test
clementetb Jun 7, 2024
1df43ea
TEST
clementetb Jun 10, 2024
c3b733f
Undo changes
clementetb Jun 10, 2024
f12ad05
Merge branch 'main' into ct/add_problem_matchers
clementetb Jun 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/problem-matchers/detekt.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"problemMatcher": [
{
"owner": "detekt",
"severity": "error",
"pattern": [
{
"regexp": "(.+\\.kt):(\\d+):(\\d+):\\s(.*)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add kts Gradle scripts?

Copy link
Contributor Author

@clementetb clementetb Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is required. We don't run detekt against our build scripts.

"file": 1,
"line": 2,
"column": 3,
"message": 4
}
]
}
]
}
40 changes: 40 additions & 0 deletions .github/problem-matchers/kotlin.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"problemMatcher": [
{
"owner": "kotlin",
"severity": "error",
"pattern": [
{
"regexp": "^e\\:\\s(?:(?:(.*):(?:\\s\\()?(\\d+)(?:(?:\\,\\s)|\\:)(\\d+))(?:\\))?\\:\\s)?(.*)$",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you come up with all these regexp? or are they already provided somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came up with them. Because we use two kotlin versions in our project (buildSrc, and regular project) we have two kinds of logs for kotlin compilation errors.

"file": 1,
"line": 2,
"column": 3,
"message": 4
}
]
},
{
"owner": "kotlin-warning",
"severity": "warning",
"pattern": [
{
"regexp": "^w\\:\\s(?:(?:(.*):(?:\\s\\()?(\\d+)(?:(?:\\,\\s)|\\:)(\\d+))(?:\\))?\\:\\s)?(.*)$",
"file": 1,
"line": 2,
"column": 3,
"message": 4
}
]
},
{
"owner": "gradle-warning",
"severity": "warning",
"pattern": [
{
"regexp": "^WARNING:(.*(?:\\n(?!w|e\\:|>|FAILURE|BUILD SUCCESSFUL).*)*)$",
"message": 1
}
]
}
]
}
17 changes: 17 additions & 0 deletions .github/problem-matchers/ktlint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"problemMatcher": [
{
"owner": "ktlint",
"severity": "error",
"pattern": [
{
"regexp": "(.+\\.kt):(\\d+):(\\d+):\\s(.*)",
"file": 1,
"line": 2,
"column": 3,
"message": 4
}
]
}
]
}
2 changes: 1 addition & 1 deletion .github/workflows/auto-merge-branches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

# Set the branch we want to merge changes into as step output. This step should list each branch name found in the `push`
# trigger in the top of this file.
Expand Down
Loading
Loading