Skip to content

misuse of .env file #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukeorland opened this issue Sep 20, 2016 · 3 comments
Open

misuse of .env file #36

lukeorland opened this issue Sep 20, 2016 · 3 comments

Comments

@lukeorland
Copy link
Contributor

The .env file at the root of the repo has special use: https://docs.docker.com/compose/env-file/

The file is sourced when docker-compose is invoked, and the values affect docker-compose commands.

My suggestion is to move the contents of the current .env file to docker-compose*.yml, under a new environment: heading.

For reference: https://docs.docker.com/compose/compose-file/#/environment

@mjhea0
Copy link
Contributor

mjhea0 commented Dec 3, 2016

Would this PR address it? #37

@imaia
Copy link

imaia commented Dec 13, 2016

#37 duplicates the environment variables twice. Would there be a better approach? .env is quite clean, even if not "right".

@bmanojlovic
Copy link

I was looking in more elegant way not using .env file but there is no good way to do it without duplicating vars :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants