removal of .env file #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve the conflicts? Thank you! |
|
Is that duplicated code? |
|
I really do not see where is conflict "resolve conflict" raises 404, so if it is possible to tell me what is wrong with my change i would gladly fix it |
|
merge the latest master into your branch and it will resolve the conflict |
|
fixed conflict |
|
thank you! i should have time to look at this later in the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR references .env file removal request #36 and by itself references #24, as now everything is set in docker-compose.yml file, what is not nice is that variables are duplicated but more visible if nothing else