Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CardElementChangeEvent type; fixes #121 #237

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

joshunger
Copy link
Contributor

@joshunger joshunger commented Oct 28, 2024

Update CardElementChangeEvent type; fixes #121

@joshunger
Copy link
Contributor Author

joshunger commented Oct 29, 2024

@chrissrogers are the Check and Unit test supposed to run on main as well? Looking at https://github.com/recurly/react-recurly/blob/main/.github/workflows/ci.yml#L6

@chrissrogers chrissrogers merged commit 563c205 into recurly:main Oct 29, 2024
3 checks passed
@chrissrogers
Copy link
Member

That's a functional alias in GitHub, from what I can tell. I tested this though and all is well. Thank you for the contrib!

@joshunger
Copy link
Contributor Author

@chrissrogers would it be possible to cut a new release with these type changes in this PR?

recurly-integrations pushed a commit that referenced this pull request Jan 30, 2025
[Full Changelog](v2.0.1...v2.0.2)

**Merged Pull Requests**

- Update CardElementChangeEvent type; fixes #121 [#237](#237) ([joshunger](https://github.com/joshunger))
- Add storybook-addon-a11y [#235](#235) ([Smolations](https://github.com/Smolations))
- Remove internal wiki link from codel config. [#226](#226) ([recurly-bearley](https://github.com/recurly-bearley))
- Adds Subscription id pass-through for useCheckoutPricing [#225](#225) ([chrissrogers](https://github.com/chrissrogers))
- Adds onReady and re-render protection to ThreeDSecureAction [#224](#224) ([chrissrogers](https://github.com/chrissrogers))

**Closed Issues**

- Dependency updates addressing`npm audit` warnings. [#202](#202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value Does Not Match Type Signature For Card Change Events
2 participants