Skip to content

DFBUGS-5556: [release-4.20] connection: refactor state management and idle timer sync#390

Merged
openshift-merge-bot[bot] merged 3 commits intored-hat-storage:release-4.20from
black-dragon74:DFBUGS-5556
Mar 12, 2026
Merged

DFBUGS-5556: [release-4.20] connection: refactor state management and idle timer sync#390
openshift-merge-bot[bot] merged 3 commits intored-hat-storage:release-4.20from
black-dragon74:DFBUGS-5556

Conversation

@black-dragon74
Copy link
Member

@black-dragon74 black-dragon74 commented Feb 13, 2026 •
edited
Loading

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Upstream PR:

Downstream commits:

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference jira/invalid-bug labels Feb 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2026 •
edited by openshift-ci bot
Loading

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@black-dragon74 black-dragon74 changed the title DFBUGS-5556: [release-4.21] connection: refactor state management and idle timer sync DFBUGS-5556: [release-4.20] connection: refactor state management and idle timer sync Feb 13, 2026
@black-dragon74
Copy link
Member Author

black-dragon74 commented Feb 13, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug labels Feb 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2026 •
edited by openshift-ci bot
Loading

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.20.6) matches configured target version for branch (odf-4.20.6)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (posharma@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@black-dragon74 black-dragon74 force-pushed the DFBUGS-5556 branch 3 times, most recently from 559d9d1 to bb11091 Compare February 16, 2026 08:05
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Feb 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2026 •
edited by openshift-ci bot
Loading

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Upstream PR:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member

nixpanic commented Mar 3, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2026 •
edited by openshift-ci bot
Loading

@nixpanic: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@black-dragon74
Copy link
Member Author

black-dragon74 commented Mar 12, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug labels Mar 12, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026 •
edited by openshift-ci bot
Loading

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com/browse/DFBUGS-5556), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.20.8) matches configured target version for branch (odf-4.20.8)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (posharma@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member

nixpanic commented Mar 12, 2026

/hold

This isn't suitable for backporting, almost 3000 files changed?! Can you reduce the changes to only the required parts and make it a clean backport without rebases?

@black-dragon74
connection: refactor state management and idle timer sync
395f8cc 
This patch does the following:
- Uses gRPC default idle timeout to close connection after 30mins.
- Removes manual work around the same.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 6680b85)
@black-dragon74
connection: add unit tests for connection
ddd0563 
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit c9d6212)
@black-dragon74 black-dragon74 force-pushed the DFBUGS-5556 branch 2 times, most recently from 3e0b063 to 259f3ac Compare March 12, 2026 08:49
@black-dragon74
[DOWNSTREAM_ONLY] controller: ignore running suite tests
0489408 
This patch disables the suite tests by excluding them
using build tags.

This is done to avoid updating env-test which in turn
leads to update of operator-sdk, resulting in massive
changes, unsuitable for a backport.

The disabled tests were just the default scaffolding of
kubebuilder.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026 •
edited by openshift-ci bot
Loading

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com/browse/DFBUGS-5556), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.20.8) matches configured target version for branch (odf-4.20.8)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (posharma@redhat.com), skipping review request.

Details

In response to this:

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Upstream PR:

Downstream commits:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member

nixpanic commented Mar 12, 2026

/unhold
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [black-dragon74,nixpanic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1fd5823 into red-hat-storage:release-4.20 Mar 12, 2026
12 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026 •
edited by openshift-ci bot
Loading

@black-dragon74: [Jira Issue DFBUGS-5556](https://issues.redhat.com/browse/DFBUGS-5556): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-5556](https://issues.redhat.com/browse/DFBUGS-5556) has been moved to the MODIFIED state.

Details

In response to this:

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Upstream PR:

Downstream commits:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nixpanic nixpanic

Labels

approved jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@black-dragon74 @openshift-ci-robot @nixpanic