Fix creating the RBD namespace command with external mode #11239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitzhak12
force-pushed
the
fix-create-rbd-namespace-command-param
branch
from
6ac85b1 to
adc4adf
Compare
pull-request-size
bot
added
size/XS
and removed
size/S
…me' if they missing from the command Signed-off-by: Itzhak Kave <[email protected]>
yitzhak12
force-pushed
the
fix-create-rbd-namespace-command-param
branch
from
adc4adf to
8bac324
Compare
pull-request-size
bot
added
size/S
…d namespace prefix, Save the 'rbd_namespace' param in the 'config.EXTERNAL_MODE' Signed-off-by: Itzhak Kave <[email protected]>
yitzhak12
force-pushed
the
fix-create-rbd-namespace-command-param
branch
from
194cd7f to
4062d46
Compare
|
I ran a test in my local, and it passed using the PR. |
petr-balogh
approved these changes
Feb 12, 2025
dahorak
approved these changes
Feb 12, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, petr-balogh, yitzhak12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR, I implemented the following:
helpersfile to take the new storageclass namewhen using the rbd namespace.
See the related bug https://issues.redhat.com/browse/DFBUGS-1300.
In external mode, we are creating the RBD storageclass using the RBD namespace prefix.