Use podman cp over podman run cat/ls when fetching CSVs for Rook

[GingerGeek]

When building a pipeline (okd-project/okd-operator-pipeline) to build and assemble the storage operators, we had issues with building OCS due to running of containers-in-a-pod as part of the pipeline.

Running a container requires additional privileges that we are trying to avoid giving to our Tekton pipeline and in this case it seemed using podman cp would provide a slightly simpler solution.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GingerGeek
Once this PR has been reviewed and has the lgtm label, please assign iamniting for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @GingerGeek. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[malayparida2000]

/ok-to-test

[malayparida2000]

/cc @subhamkrai I think you were working on something else related to this, PTAL

[GingerGeek]

Thanks, I also noted that the Rook CRDs currently in the repo all have CRLF line endings. The cp command will replace them with LF but not sure if that should be included in this PR or not?

[openshift-ci]

@GingerGeek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocs-operator-bundle-e2e-aws	aeef254	link	true	/test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Nikhil-Ladha]

We won't be needing these changes, once we are set to take this PR in #2492
@GingerGeek is this issue with rook CRDs,CSV a blocker for now? Can we hold it off for some more days or so?

[GingerGeek]

It's not a blocker no, especially if you're planning to switch away. We currently hold this PR as a patch on our build pipeline for this repository. cc/ @SupremeMortal

[jarrpa]

@GingerGeek Will PR #2492 still work for you if it's using operator-sdk run bundle? https://sdk.operatorframework.io/docs/cli/operator-sdk_run_bundle/ You may want to verify this.

[jarrpa]

For what it's worth, I have some dev patches where I"m using kustomize to deploy rook-ceph-operator from within this repo, and moving away from using podman directly would be a step backwards for me. I like not using OLM where I don't have to. 😝

[GingerGeek]

I'm not sure, if there's an underlying use of a running container then it would likely fail in our current pipelines as podman-in-okd-pods is non-trivial if you want to maintain non-privileged running.

We may have to bite the bullets and just start running builds in privileged contexts.

It's worth mentioning that this method of us taking a project like this and running the build ourself is a somewhat stop-gap measure to help bootstrap operators-on-okd.

Our overall goal would be for the OKD catalog to be a first-class destination for any upstream operators that package into Openshift. So ie you folks on this project would have CI/CD to build operator bundles and then submit that into our catalog. Happy to partake in any community process that would help make that happen

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.