-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make install Procedure to README for Installation #2978
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OdedViner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3cb0a3c
to
ad4ad26
Compare
ad4ad26
to
90bead1
Compare
README.md
Outdated
- [Debugging Functional Test Failures](#debugging-functional-test-failures) | ||
- [Functional test stdout log](#functional-test-stdout-log) | ||
- [PROW artifacts](#prow-artifacts) | ||
- [Table of Contents](#table-of-contents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table of contents is duplicated as it is already a header above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just add to the Installation section without changing anything else in the contents section, so the git diff remains clean.
README.md
Outdated
#### Option 1: Using `make install` | ||
If you have a development environment or private image and want to install the OCS operator, follow the steps below: | ||
|
||
1.Label Worker Nodes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of numbered steps please use bullted steps which can help in inserting new steps in future without ordering change.
Signed-off-by: Oded Viner <[email protected]>
90bead1
to
bf49c1a
Compare
Signed-off-by: Oded Viner <[email protected]>
250fd66
to
b9cc5a4
Compare
Signed-off-by: Oded Viner <[email protected]>
Signed-off-by: Oded Viner <[email protected]>
@OdedViner: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
#2972
This PR enhances the Installation section of the ocs-operator README by adding a new installation option using the
make install
command. Themake install
method provides a streamlined way to deploy the OCS operator in development environments or with private images.