Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated go1.23.0 to go 1.23.5 as CVE-2024-45336 is fixed in go 1.23.5… #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrudraia1
Copy link

odf-cli security vulnerability issue.

Issue: CVE-2024-45336 golang: net/http: net/http: sensitive headers incorrectly sent after cross-domain redirect

The present version of go1.23.0 is upgraded to go 1.23.5 as this issue is fixed in l.23.5.

go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/red-hat-storage/odf-cli

go 1.23.0
go 1.23.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.23.5
go 1.23.5

instead let's update the toolchain version and first let's do this in kubectl-rook-ceph repo.

And also @mrudraia1 will you be interested in updating in rook/rook repo too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the go toolchain version

… version

Signed-off-by: Mrudraia1 <[email protected]>

Signed-off-by: Mrudraia1 <[email protected]>
Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrudraia1
Once this PR has been reviewed and has the lgtm label, please ask for approval from subhamkrai. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants