update controller-gen version and generate updated manifests#291
Conversation
Signed-off-by: Umanga Chapagain <uchapaga@redhat.com>
| - pods | ||
| - secrets | ||
| verbs: | ||
| - '*' |
There was a problem hiding this comment.
Limit the actions to just the required ones ? I don't think we require (get, delete, watch, patch, updates) for pods or events ?
There was a problem hiding this comment.
I did not add these changes. The controller-gen update did some changes to this based on existing RBACs.
I have a task created to cleanup RBACs. I'll do it soon when the features are complete.
| - create | ||
| - get | ||
| - list | ||
| - update |
There was a problem hiding this comment.
Same here ? Do we perform all of these actions ?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e243653
into
red-hat-storage:main
2 participants
No description provided.