-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added process ids to list and wait for them to finish #107
Conversation
Signed-off-by: oviner <[email protected]>
@OdedViner: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This looks good to me. WDYT @yati1998? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: black-dragon74, OdedViner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the ci seems to fail, maybe a rebase is needed. |
/retest |
I think that we don't have a proper CI in place for 4.14 branch. I am taking a note and will implement it for 4.14 branch. Until then, manual approvals is the way to go. Regards |
@OdedViner: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.