Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added process ids to list and wait for them to finish #107

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

OdedViner
Copy link
Contributor

No description provided.

Copy link
Contributor

openshift-ci bot commented Jan 14, 2024

@OdedViner: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Added process ids to list and wait for them to finish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@black-dragon74
Copy link
Member

This looks good to me. WDYT @yati1998?

@black-dragon74
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, OdedViner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yati1998
Copy link
Member

the ci seems to fail, maybe a rebase is needed.

@black-dragon74
Copy link
Member

/retest

@black-dragon74
Copy link
Member

the ci seems to fail, maybe a rebase is needed.

I think that we don't have a proper CI in place for 4.14 branch. I am taking a note and will implement it for 4.14 branch. Until then, manual approvals is the way to go.

Regards

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@OdedViner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-must-gather 9080546 link true /test odf-must-gather

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yati1998 yati1998 merged commit c45d485 into red-hat-storage:release-4.14 Feb 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants