collect resources for openshift-storage-extended ns #124
Conversation
This commit collects crds and few resources for openshift-storage-extended namespace Signed-off-by: yati1998 <[email protected]>
| done | ||
|
|
||
| # NOTE: This is a temporary fix for collecting the storagecluster as we are not able to collect the storagecluster using the inspect command |
There was a problem hiding this comment.
why we have this change from 105-109, why is this shifted inside the loop?
There was a problem hiding this comment.
+1, did we collect values from "only one" namespace before?
The new code makes much sense but I am asking as to why nobody brought it up earlier?
Regards
There was a problem hiding this comment.
Seems we didn't notice earlier, but the INSTALL_NAMESPACE has more than one namespace and it should be inside the loop, orelse it wont collect the info. Just a part of cleanup.
There was a problem hiding this comment.
Just noticed this bug in code while testing for extended namespace.
There was a problem hiding this comment.
Just noticed this bug in code while testing for extended namespace.
While you're at it can you see if the inspect method works now? If so we can use that instead of the current workaround.
Regards
There was a problem hiding this comment.
inspect is the part of oc and I don't think it was added. I still see we can't collect it through inspect.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.15 |
|
@yati1998: new pull request created: #125 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: black-dragon74 <[email protected]>
Fix error induced at: #124
Signed-off-by: black-dragon74 <[email protected]>
…29-to-release-4.15 Bug 2268407: [release-4.15] Fix error induced at: #124
This commit collects crds and few resources for
openshift-storage-extended namespace