Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2308101: logrotate: add logrotate functionality for csi operator #191

Merged

Conversation

parth-gr
Copy link
Member

currently client operator has started using csi operator so collecting the csi logs from a new host path
hat csi-operator supports

currently client operator has started using csi operator
so collecting the csi logs from a new host path
hat csi-operator supports

Signed-off-by: parth-gr <[email protected]>
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

@parth-gr: This pull request references Bugzilla bug 2308101, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

Bug 2308101: logrotate: add logrotate functionality for csi operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@parth-gr: This pull request references Bugzilla bug 2308101, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

Bug 2308101: logrotate: add logrotate functionality for csi operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@parth-gr
Copy link
Member Author

/assign @yati1998 @black-dragon74

@parth-gr
Copy link
Member Author

once this is merged I will manually update the 4.17 backport with this commit

@parth-gr
Copy link
Member Author

can we get a /lgtm approval?

@openshift-ci openshift-ci bot added the lgtm label Aug 28, 2024
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: parth-gr, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@black-dragon74
Copy link
Member

/hold

@black-dragon74
Copy link
Member

@parth-gr please address the suggested changes.

@openshift-merge-bot openshift-merge-bot bot merged commit 6e482db into red-hat-storage:main Aug 28, 2024
5 checks passed
@parth-gr
Copy link
Member Author

parth-gr commented Aug 28, 2024

@parth-gr please address the suggested changes.

sorry are you looking for something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants