Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from main for odf-must-gather #223

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

df-build-team
Copy link

PR containing the latest commits from main branch

black-dragon74 and others added 2 commits January 29, 2025 18:54
The MG currently uses `-empty` with find to remove
the empty files. This only works for files with a
size of 0 bytes.

In cases where the file has an empty line or a single
character this doesn't work.

This patch updates the logic to also consider files with
LF endings (just a new line)

Signed-off-by: Niraj Yadav <[email protected]>
gather: Fix removal of empty files from gather
@df-build-team df-build-team requested a review from a team February 4, 2025 03:53
@black-dragon74
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, df-build-team

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c39a0c3 into release-4.19 Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants