Syncing latest changes from upstream main for ramen #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated using: - go get - go mod tidy To address CVE https://nvd.nist.gov/vuln/detail/CVE-2023-44487 Signed-off-by: Shyamsundar Ranganathan <[email protected]>
*** THIS IS A HACK!!! To remove the k8s and subsequent go mod dependency problems, selectively define a local ArgoCD ApplicationSet type within the code, and use the same for listing and looking at required fields in an ApplicationSet. If ArgoCD API versions change, we may have to relook at the fields and which are non-optional, to redo parts of this for the next API version. Signed-off-by: Shyamsundar Ranganathan <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream main branch