Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2257480: Reconcile related drpcs when drcluster is deleted #173

Merged

Conversation

nirs
Copy link

@nirs nirs commented Jan 16, 2024

  • When filtering update events, consider also the update when the new object is marked for deletion.
  • When filtering drpcs consider all drpcs referencing a deleted drcluster.

With this change, when a drcluster is deleted, the drpc controller updates the VRG ManifestWork on the remaining cluster. Previously this happened minutes after a drcluster was deleted.

Notes:

  • We don't get a delete event when the drcluster is deleted, but an update event. I don't know if this is a bug in controller runtime or expected behavior.

Signed-off-by: Nir Soffer [email protected]
(cherry picked from commit 2b66f98)

Change tested upstream with drenv and ocp.

Copy link

openshift-ci bot commented Jan 16, 2024

@nirs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Reconcile related drpcs when drcluster is deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- When filtering update events, consider also the update when the new
  object is marked for deletion.
- When filtering drpcs consider all drpcs referencing a deleted
  drcluster.

With this change, when a drcluster is deleted, the drpc controller
updates the VRG ManifestWork on the remaining cluster. Previously this
happened minutes after a drcluster was deleted.

Notes:

- We don't get a delete event when the drcluster is deleted, but an
  update event. I don't know if this is a bug in controller runtime or
  expected behavior.

Signed-off-by: Nir Soffer <[email protected]>
(cherry picked from commit 2b66f98)
Signed-off-by: Nir Soffer <[email protected]>
@nirs nirs force-pushed the update-vrg-release-4.15 branch from d01cfc1 to d107f69 Compare January 16, 2024 17:51
@nirs nirs changed the title Reconcile related drpcs when drcluster is deleted Bug 2257480: Reconcile related drpcs when drcluster is deleted Jan 16, 2024
@ShyamsundarR
Copy link

/bugzilla refresh

Copy link

openshift-ci bot commented Jan 16, 2024

@ShyamsundarR: Bugzilla bug 2257480 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nirs, ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShyamsundarR ShyamsundarR merged commit 397676e into red-hat-storage:release-4.15 Jan 16, 2024
12 of 13 checks passed
@nirs nirs deleted the update-vrg-release-4.15 branch January 16, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants