Skip to content

Commit

Permalink
Bug 2242324: fetch performance metrics from prometheus exporter for 4.13
Browse files Browse the repository at this point in the history
Enable functionality for fetching performance counters of ceph daemons in
prometheus module by setting `exclude_perf_counters` to false

Signed-off-by: Avan Thakkar <[email protected]>
  • Loading branch information
Avan committed Feb 1, 2024
1 parent 42f4376 commit 8c075a4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/operator/ceph/cluster/mgr/mgr.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ func (c *Cluster) Start() error {

// configure the mgr modules
c.configureModules(daemonIDs)

// Fetch performance counters from the prometheus exporter as ceph-exporter is disabled for 4.13
err = monStore.Set("mgr", "mgr/prometheus/exclude_perf_counters", false)

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / unittests

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / linux-build-all (1.19)

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / linux-build-all (1.20)

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / golangci-lint

undefined: monStore) (typecheck)

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / golangci-lint

undefined: monStore) (typecheck)

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / golangci-lint

undefined: monStore (typecheck)

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / golangci-lint

undefined: monStore) (typecheck)

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / macos-build

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / csi-hostnetwork-disabled

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / encryption

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / encryption-pvc

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / canary

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / encryption-pvc-db

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / encryption-pvc-kms-vault-token-auth

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / encryption-pvc-db-wal

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / lvm-pvc

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / multi-cluster-mirroring

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / osd-with-metadata-device

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / encryption-pvc-kms-vault-k8s-auth

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / pvc

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / multus-cluster-network

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / lvm

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / rgw-multisite-testing

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / pvc-db-wal

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / pvc-db

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / raw-disk

undefined: monStore

Check failure on line 210 in pkg/operator/ceph/cluster/mgr/mgr.go

View workflow job for this annotation

GitHub Actions / two-osds-in-device

undefined: monStore
if err != nil {
return errors.Wrapf(err, "failed to enable exclude_perf_counters")
}
return nil
}

Expand Down

0 comments on commit 8c075a4

Please sign in to comment.