Bug 2257371: external: include 255 as a valid ip range #555

subhamkrai · 2024-01-11T13:28:00Z

Description of your changes:
external: include 255 as a valid ip range

external script was checking ip range up to 254
which is incorrect, the valid range is 0-255
and if someone passes 255 it will through error like
```
Out of range IP addresses
```
so including 255 as a valid range.

Checklist:

Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
Reviewed the developer guide on Submitting a Pull Request
Pending release notes updated with breaking and/or notable changes for the next minor release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.

openshift-ci · 2024-01-11T13:28:07Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2257371: external: include 255 as a valid ip range

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

parth-gr · 2024-01-11T13:34:40Z

deploy/examples/create-external-cluster-resources.py

@@ -549,7 +549,7 @@ def _invalid_endpoint(self, endpoint_str):
                    f"IP address parts should be numbers: {ipv4}"
                )
            intPart = int(eachPart)
-            if intPart < 0 or intPart > 254:
+            if intPart < 0 or intPart > 255:


in the unit test you can check, can you add a small test
And do we need upstream fix for this in lower version

I'm not planning to add a unit test for this as the future version already has an appropriate fix. And I don't think we are doing any release for the upstream version of this older version.

maybe a check with ip: 1x.x.xxx.255 like this in the ci
But moreover it looks fine

openshift-ci · 2024-01-11T13:34:48Z

@parth-gr: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

parth-gr · 2024-01-11T14:32:18Z

deploy/examples/create-external-cluster-resources.py

@@ -549,7 +549,7 @@ def _invalid_endpoint(self, endpoint_str):
                    f"IP address parts should be numbers: {ipv4}"
                )
            intPart = int(eachPart)
-            if intPart < 0 or intPart > 254:
+            if intPart < 0 or intPart > 255:


maybe a check with ip: 1x.x.xxx.255 like this in the ci
But moreover it looks fine

openshift-ci · 2024-01-11T14:32:26Z

@parth-gr: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-01-11T14:32:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parth-gr, subhamkrai
Once this PR has been reviewed and has the lgtm label, please assign travisn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

external script was checking ip range up to 254 which is incorrect, the valid range is 0-255 and if someone passes 255 it will through error like ``` Out of range IP addresses ``` so including 255 as a valid range. Signed-off-by: subhamkrai <[email protected]>

openshift-ci · 2024-01-12T06:18:03Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2257371: external: include 255 as a valid ip range

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2024-01-17T08:20:04Z

/bugzilla refresh

openshift-ci · 2024-01-17T08:20:08Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2024-01-17T08:28:44Z

/bugzilla refresh

openshift-ci · 2024-01-17T08:28:51Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (ODF 4.13.7) matches configured target release for branch (ODF 4.13.7)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-01-17T08:28:54Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@subhamkrai: This pull request references Bugzilla bug 2257371, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (ODF 4.13.7) matches configured target release for branch (ODF 4.13.7)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2024-01-17T08:37:11Z

@travisn CI errors are fixed in newer versions, I don't think my changes are affecting this.

Let me know wdyt, should we go ahead with these changes or need to fix CI.

travisn · 2024-01-17T20:53:58Z

@subhamkrai Agreed the CI issues are not related. We can merge this when it's approved.

subhamkrai · 2024-02-01T05:38:16Z

/bugzilla refresh

openshift-ci · 2024-02-01T05:38:22Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "ODF 4.13.8" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2024-02-08T15:20:23Z

/bugzilla refresh

openshift-ci · 2024-02-08T15:20:29Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "ODF 4.13.8" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2024-02-08T15:21:35Z

@subhamkrai: This pull request references Bugzilla bug 2257371, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "ODF 4.13.8" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

@agarwal-mudit we need to fix this for the bot? any idea where I can fix this?

agarwal-mudit · 2024-02-09T05:57:05Z

/bugzilla refresh

openshift-ci · 2024-02-09T05:57:12Z

@agarwal-mudit: This pull request references Bugzilla bug 2257371, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (ODF 4.13.8) matches configured target release for branch (ODF 4.13.8)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-02-09T05:57:15Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references Bugzilla bug 2257371, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (ODF 4.13.8) matches configured target release for branch (ODF 4.13.8)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subhamkrai · 2024-02-09T06:32:57Z

I think we can go ahead with PR multiple CI fixes are not backported to 4.14 and earlier branches, For examplehttps://github.com//pull/569

openshift-ci · 2024-02-09T06:34:43Z

@subhamkrai: All pull requests linked via external trackers have merged:

red-hat-storage/rook#555

Bugzilla bug 2257371 has been moved to the MODIFIED state.

In response to this:

Bug 2257371: external: include 255 as a valid ip range

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 11, 2024

parth-gr suggested changes Jan 11, 2024

View reviewed changes

parth-gr approved these changes Jan 11, 2024

View reviewed changes

subhamkrai force-pushed the update-ip-range branch from 7c96223 to 4094652 Compare January 12, 2024 06:17

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 17, 2024

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 1, 2024

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 1, 2024

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 9, 2024

agarwal-mudit merged commit de60f14 into red-hat-storage:release-4.13 Feb 9, 2024
15 of 47 checks passed

subhamkrai deleted the update-ip-range branch February 9, 2024 06:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2257371: external: include 255 as a valid ip range #555

Bug 2257371: external: include 255 as a valid ip range #555

subhamkrai commented Jan 11, 2024 •

edited

Loading

openshift-ci bot commented Jan 11, 2024

parth-gr Jan 11, 2024

subhamkrai Jan 11, 2024

parth-gr Jan 11, 2024

openshift-ci bot commented Jan 11, 2024

parth-gr Jan 11, 2024

openshift-ci bot commented Jan 11, 2024

openshift-ci bot commented Jan 11, 2024

openshift-ci bot commented Jan 12, 2024

subhamkrai commented Jan 17, 2024

openshift-ci bot commented Jan 17, 2024

subhamkrai commented Jan 17, 2024

openshift-ci bot commented Jan 17, 2024

openshift-ci bot commented Jan 17, 2024

subhamkrai commented Jan 17, 2024

travisn commented Jan 17, 2024

subhamkrai commented Feb 1, 2024

openshift-ci bot commented Feb 1, 2024

subhamkrai commented Feb 8, 2024

openshift-ci bot commented Feb 8, 2024

subhamkrai commented Feb 8, 2024 •

edited

Loading

agarwal-mudit commented Feb 9, 2024

openshift-ci bot commented Feb 9, 2024

openshift-ci bot commented Feb 9, 2024

subhamkrai commented Feb 9, 2024

openshift-ci bot commented Feb 9, 2024

Bug 2257371: external: include 255 as a valid ip range #555

Bug 2257371: external: include 255 as a valid ip range #555

Conversation

subhamkrai commented Jan 11, 2024 • edited Loading

openshift-ci bot commented Jan 11, 2024

parth-gr Jan 11, 2024

Choose a reason for hiding this comment

subhamkrai Jan 11, 2024

Choose a reason for hiding this comment

parth-gr Jan 11, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Jan 11, 2024

parth-gr Jan 11, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Jan 11, 2024

openshift-ci bot commented Jan 11, 2024

openshift-ci bot commented Jan 12, 2024

subhamkrai commented Jan 17, 2024

openshift-ci bot commented Jan 17, 2024

subhamkrai commented Jan 17, 2024

openshift-ci bot commented Jan 17, 2024

openshift-ci bot commented Jan 17, 2024

subhamkrai commented Jan 17, 2024

travisn commented Jan 17, 2024

subhamkrai commented Feb 1, 2024

openshift-ci bot commented Feb 1, 2024

subhamkrai commented Feb 8, 2024

openshift-ci bot commented Feb 8, 2024

subhamkrai commented Feb 8, 2024 • edited Loading

agarwal-mudit commented Feb 9, 2024

openshift-ci bot commented Feb 9, 2024

openshift-ci bot commented Feb 9, 2024

subhamkrai commented Feb 9, 2024

openshift-ci bot commented Feb 9, 2024

subhamkrai commented Jan 11, 2024 •

edited

Loading

subhamkrai commented Feb 8, 2024 •

edited

Loading