-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2265124: csi: remove cephFs networkFence code temporarily #578
Bug 2265124: csi: remove cephFs networkFence code temporarily #578
Conversation
update go.mod to use csi-addons version v0.8.0. Signed-off-by: subhamkrai <[email protected]> (cherry picked from commit c3f4be4)
earlier, we were only checking the specs of networkFence to see if unfencing is done before proceeding with deletion but we should also check the status of networkFence before proceeding with deletion. Signed-off-by: subhamkrai <[email protected]> (cherry picked from commit 0ace7cf) (cherry picked from commit 5a15f6a)
cephFs fencing needs more testing and bug fixes to make it in production. We tried multiple fixes but still it need more work. So, removing the cephfs networkFence realted code will rever this commit when we start working on this again. Signed-off-by: subhamkrai <[email protected]> (cherry picked from commit bd4250f) (cherry picked from commit 28182e9)
@subhamkrai: This pull request references Bugzilla bug 2265124, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We can merge this once backport pr merges in rook rook#13806 |
/bugzilla refresh |
@agarwal-mudit: This pull request references Bugzilla bug 2265124, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is ready to merge |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhamkrai, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@subhamkrai: All pull requests linked via external trackers have merged: Bugzilla bug 2265124 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please check individual commits.
Checklist: