-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new rook bundle creation script #584
Conversation
8f2a5b0
to
320df87
Compare
IIRC, this master branch is just a resync of the master branch from github.com/rook/rook. I think these changes will be un-done the next time the branches are synced. Am I missing something? Or is there a way to make these changes to the Rook upstream as well? |
The resync should just be bringing the commits from upstream to the downstream. It's not resetting the branch, so the only risk of making changes in the downstream master should be if there are merge conflicts. Also it's important to note that the downstream release branches will be created directly from the upstream branches, so any commits in the downstream master would not be included in the downstream release branches IIUC. |
The release branches created now are being synced from the downstream master only, though I guess once we have an upstream release that would be reset to an upstream release branch. So, once we get these changes into the master branch d/s, these changes would be synced to the release branch as well. |
320df87
to
5d10acd
Compare
5d10acd
to
138d7e0
Compare
Tested the changes and everything is working fine |
138d7e0
to
f86cc53
Compare
@iamniting: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c71498a
to
22046d7
Compare
Added Dockerfile to create rook-ceph-operator-bundle under the rook repo. Updated the Makefile to have the 'bundle' command, that reference the 'gen-bundle.sh' script under `build/bundle`. Moved the rook csv under build/csv/ceph directory to keep all the manifests at one location for bundle creation Signed-off-by: Nikhil-Ladha <[email protected]>
22046d7
to
50cce65
Compare
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha, sp98, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
build/bundle
.Checklist: