Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add new env value ref for operator #600

Closed
wants to merge 1 commit into from

Conversation

leelavg
Copy link

@leelavg leelavg commented Mar 23, 2024

Add ability to read disable csi driver value from env set in ocs-operator configmap.

Depends on rook#13966, #601

Copy link

openshift-ci bot commented Mar 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Author

leelavg commented Mar 23, 2024

/hold

till rook#13966 gets merged.

do not unhold.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2024
@leelavg leelavg force-pushed the disable-driver-end branch from 736a2c8 to 1bb9cce Compare March 26, 2024 09:52
@subhamkrai
Copy link

@leelavg @parth-gr IMO these changes should be part of #601 is there any concern if we cherry-pick this commit to #601

@leelavg
Copy link
Author

leelavg commented Mar 26, 2024

@leelavg @parth-gr IMO these changes should be part of #601 is there any concern if we cherry-pick this commit to #601

  • I'm fine w/ clubbing this to 601.

@leelavg
Copy link
Author

leelavg commented Mar 26, 2024

closing in favor of #601

@leelavg leelavg closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants