Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider name in rook csv #602

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix provider name in rook csv #602

merged 2 commits into from
Mar 27, 2024

Conversation

Nikhil-Ladha
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha commented Mar 27, 2024

Fix provider name in rook csv i.e, use Red Hat for the name and url field.
Also, moved the provider field to metadata-common.yaml file so that defaults are overridden during the csv generation.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Moved provider field to metadata-common.yaml file,
such that it overrides the default in the rook csv

Signed-off-by: Nikhil-Ladha <[email protected]>
add generated changes for csv

Signed-off-by: Nikhil-Ladha <[email protected]>
Copy link

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikhil-Ladha From where these changes are coming? I mean is there any issue or something?

@Nikhil-Ladha
Copy link
Member Author

@Nikhil-Ladha From where these changes are coming? I mean is there any issue or something?

The thing is the csv is not updated with correct provider details right now, because we are using MERGE cmd in the gen-csv script for metadat-ocp.yaml file. That's the reason I moved it to metadata-common.yaml and now the csv has the correct data.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nikhil-Ladha, subhamkrai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit 489e6f7 into master Mar 27, 2024
48 of 49 checks passed
@subhamkrai subhamkrai deleted the fix-provider-name branch March 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants