Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv: update csv version to 4.16 #606

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

subhamkrai
Copy link

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
Copy link

openshift-ci bot commented Mar 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

updating csv version to 4.16 from 4.15

Signed-off-by: subhamkrai <[email protected]>
adding `csv` as new commit title for csv related changes.

Signed-off-by: subhamkrai <[email protected]>
@subhamkrai subhamkrai marked this pull request as ready for review March 28, 2024 06:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@subhamkrai subhamkrai changed the title Update csv version csv: update csv version to 4.16 Mar 28, 2024
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the csv as well by running the make gen-csv cmd, as a separate commit.

these are auto generated changes

Signed-off-by: subhamkrai <[email protected]>
@subhamkrai
Copy link
Author

Please update the csv as well by running the make gen-csv cmd, as a separate commit.

missed that, added it now. Thanks

@subhamkrai subhamkrai requested a review from Nikhil-Ladha March 28, 2024 07:38
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nikhil-Ladha, subhamkrai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit 1b45dc2 into red-hat-storage:master Mar 28, 2024
48 of 49 checks passed
@subhamkrai subhamkrai deleted the update-csv-version branch March 28, 2024 10:35
@parth-gr
Copy link
Member

/cherry-pick release-4.16

@openshift-cherrypick-robot

@parth-gr: cannot checkout release-1.16: error checking out "release-1.16": exit status 1 error: pathspec 'release-1.16' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@parth-gr: new pull request created: #610

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants