-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csv: add annotation to make rook non-standalone #622
csv: add annotation to make rook non-standalone #622
Conversation
55a11df
to
bb8a9fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the logo to Red Hat logo as well.
yes we do need to. |
we don't want to show rook-ceph operator as a standalone operator in openshift installed operator list. So, adding annotation `operators.operatorframework.io/operator-type: non-standalone` to skip listing rook-ceph. Signed-off-by: subhamkrai <[email protected]>
these are auto generated changes after running make gen-csv Signed-off-by: subhamkrai <[email protected]>
bb8a9fd
to
bfe94e9
Compare
done, I copied from ocs-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nikhil-Ladha, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.16 |
@subhamkrai: new pull request created: #635 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
csv: add annotation to make rook non-standalone
we don't want to show rook-ceph operator as a standalone
operator in openshift installed operator list. So, adding
annotation
operators.operatorframework.io/operator-type: non-standalone
to skip listing rook-ceph.
Checklist: