Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv: add annotation to make rook non-standalone #622

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

subhamkrai
Copy link

csv: add annotation to make rook non-standalone

we don't want to show rook-ceph operator as a standalone
operator in openshift installed operator list. So, adding
annotation operators.operatorframework.io/operator-type: non-standalone
to skip listing rook-ceph.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@subhamkrai subhamkrai force-pushed the add-csv-annotation branch 2 times, most recently from 55a11df to bb8a9fd Compare April 12, 2024 07:05
@subhamkrai
Copy link
Author

@Nikhil-Ladha @iamniting ^^

Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the logo to Red Hat logo as well.

@iamniting
Copy link
Member

We need to update the logo to Red Hat logo as well.

yes we do need to.

we don't want to show rook-ceph operator as a standalone
operator in openshift installed operator list. So, adding
annotation `operators.operatorframework.io/operator-type: non-standalone`
to skip listing rook-ceph.

Signed-off-by: subhamkrai <[email protected]>
these are auto generated changes after running
make gen-csv

Signed-off-by: subhamkrai <[email protected]>
@subhamkrai
Copy link
Author

We need to update the logo to Red Hat logo as well.

done, I copied from ocs-operator

@subhamkrai subhamkrai requested a review from Nikhil-Ladha April 15, 2024 07:36
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nikhil-Ladha, subhamkrai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit 5a0f7f8 into red-hat-storage:master Apr 15, 2024
50 of 51 checks passed
@subhamkrai
Copy link
Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@subhamkrai: new pull request created: #635

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants