Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2276532: osd: Legacy osds on lvm pvcs crash on resize init container #631

Merged
merged 1 commit into from
May 2, 2024

Conversation

travisn
Copy link

@travisn travisn commented Apr 22, 2024

OSDs on LVM-mode PVCs are failing to come up and crashing in the expand-bluefs init container. To avoid the crash and allow the OSDs to start, a workaround was found to simply remove that init container. Now we disable the OSD resize for this case to avoid others hitting this during upgrade as well.

Signed-off-by: Travis Nielsen [email protected]
(cherry picked from commit acd7b4f) (cherry picked from commit d0fbec4)

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2276532

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

OSDs on LVM-mode PVCs are failing to come up and crashing
in the expand-bluefs init container. To avoid the crash
and allow the OSDs to start, a workaround was found to
simply remove that init container. Now we disable the
OSD resize for this case to avoid others hitting this
during upgrade as well.

Signed-off-by: Travis Nielsen <[email protected]>
(cherry picked from commit acd7b4f)
(cherry picked from commit d0fbec4)
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2024
Copy link

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 22, 2024

@travisn: This pull request references Bugzilla bug 2276532, which is invalid:

  • expected the bug to target the "ODF 4.15.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2276532: osd: Legacy osds on lvm pvcs crash on resize init container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@travisn
Copy link
Author

travisn commented May 2, 2024

/bugzilla refresh

Copy link

openshift-ci bot commented May 2, 2024

@travisn: This pull request references Bugzilla bug 2276532, which is invalid:

  • expected the bug to target the "ODF 4.15.2" release, but it targets "ODF 4.15.3" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link
Author

travisn commented May 2, 2024

Approved for 4.15.3, merging...

@travisn travisn merged commit 6896a3b into red-hat-storage:release-4.15 May 2, 2024
46 of 48 checks passed
@travisn travisn deleted the bp-4.15-lvm-osd branch May 2, 2024 17:59
Copy link

openshift-ci bot commented May 2, 2024

@travisn: All pull requests linked via external trackers have merged:

Bugzilla bug 2276532 has been moved to the MODIFIED state.

In response to this:

Bug 2276532: osd: Legacy osds on lvm pvcs crash on resize init container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant