Syncing latest changes from upstream master for rook #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a cluster never succeeds if CSI driver is disabled So to fix that we need to always create the csi configmap closes: rook#14123 Signed-off-by: parth-gr <[email protected]>
Some function names in the comments do not match. This PR will fix such problems. Signed-off-by: findmyhappy <[email protected]>
csi: create csi configmap if csi controller is disabled
core: fix function names in comment
delete duplicate words and revise the names of some methods Signed-off-by: momantech <[email protected]>
Below sidecars are updated with latest available versions csi-node-driver-registrar: v2.10.1 csi-resizer: v1.10.1 csi-provisioner: v4.0.1 csi-attacher: v4.5.1 csi-snapshotter: v7.0.2 Signed-off-by: Praveen M <[email protected]>
…rsions csi: update csi sidecars image version
docs: delete duplicate words and revise the names of some methods
in case of portable mons, mon scaledown was skipped
with below code
```
if mon.NodeName == "" {
logger.Debugf("mon %q is not scheduled to a specific host", mon.DaemonName)
continue
}
```
which skips mon removal if mon nodeName is empty
but if mons are scale down in case of portable mons
in that case also we want to remove extra mons to match
the cephCluster configuration.
Signed-off-by: subhamkrai <[email protected]>
mon: fix mon scaledown when mons are portable
This PR will add separate directory to handle the external manifest. Here external manifests will have same namespace (rook-ceph) for external cluster. Signed-off-by: smoshiur1237 <[email protected]>
external: Restructure external cluster examples manifests
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch