Bug 2279992: csi: add a new flag to disable csi driver

[parth-gr]

added a new flag ROOK_CSI_DISABLE_DRIVER
to disable csi controller.

(cherry picked from commit a72e029)

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[openshift-ci]

@parth-gr: This pull request references Bugzilla bug 2279992, which is invalid:

• expected the bug to target the "ODF 4.15.3" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2279992: csi: add a new flag to disable csi driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[parth-gr]

/hold

[parth-gr]

/unhold

[agarwal-mudit]

/bugzilla refresh

[openshift-ci]

@agarwal-mudit: This pull request references Bugzilla bug 2279992, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (ODF 4.15.3) matches configured target release for branch (ODF 4.15.3)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[parth-gr]

govulncheck CI test has been failing from a long, I tried to update it the version of it(v0.23) where the bug is fixed but its linked to multiple dependencies https://pkg.go.dev/vuln/GO-2024-2687

Scanning your code and 972 packages across 125 dependent modules for known vulnerabilities...
=== Symbol Results ===
Vulnerability #1: GO-2024-2687
    HTTP/2 CONTINUATION flood in net/http
  More info: https://pkg.go.dev/vuln/GO-2024-2687
  Standard library
    Found in: net/[email protected]
    Fixed in: net/[email protected]
    Example traces found:

And we also need to update the k8s version because of this, so lets cover this in a separate PR later.

[parth-gr]

/assigned @sp98

[github-actions]

Thanks for taking this issue! Let us know if you have any questions!

[leelavg]

Approving based on running an image w/ this content.

[openshift-ci]

@leelavg: changing LGTM is restricted to collaborators

In response to this:

Approving based on running an image w/ this content.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, parth-gr
Once this PR has been reviewed and has the lgtm label, please assign subhamkrai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@parth-gr: All pull requests linked via external trackers have merged:

• red-hat-storage/rook#647

Bugzilla bug 2279992 has been moved to the MODIFIED state.

In response to this:

Bug 2279992: csi: add a new flag to disable csi driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[parth-gr]

/backport-4.14

[rewantsoni]

/help

[rewantsoni]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@rewantsoni: #647 failed to apply on top of branch "release-4.14":

Applying: csi: add a new flag to disable csi driver
Using index info to reconstruct a base tree...
M	Documentation/Helm-Charts/operator-chart.md
M	deploy/charts/rook-ceph/templates/configmap.yaml
M	deploy/charts/rook-ceph/values.yaml
M	deploy/examples/operator-openshift.yaml
M	deploy/examples/operator.yaml
M	pkg/operator/ceph/csi/controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/ceph/csi/controller.go
Auto-merging deploy/examples/operator.yaml
CONFLICT (content): Merge conflict in deploy/examples/operator.yaml
Auto-merging deploy/examples/operator-openshift.yaml
CONFLICT (content): Merge conflict in deploy/examples/operator-openshift.yaml
Auto-merging deploy/charts/rook-ceph/values.yaml
CONFLICT (content): Merge conflict in deploy/charts/rook-ceph/values.yaml
Auto-merging deploy/charts/rook-ceph/templates/configmap.yaml
Auto-merging Documentation/Helm-Charts/operator-chart.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 csi: add a new flag to disable csi driver
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.