Bug 2281619: build: update go mod #649
Conversation
|
@parth-gr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parth-gr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| @@ -11,6 +11,8 @@ | |||
| limitations under the License. | |||
| """ | |||
|
|
|||
| # pylint: disable=E0606 | |||
There was a problem hiding this comment.
What is E0606? This isn't disabled in the master branch. What is causing it to need disabled here?
Also, please be sure to comment what rule is being disabled and why alongside linter directives like these so they can be inspected more easily in the future as things change.
There was a problem hiding this comment.
It is recently disabled by this rook#14203
There was a problem hiding this comment.
I see that the target = None change is present here (https://github.com/rook/rook/pull/14204/files) but not in this PR. Would it make more sense to use cherry-pick -x to include that commit here instead of copying only one part of its change?
There was a problem hiding this comment.
I dont think so that is related to the CI
parth-gr
force-pushed
the
govulncheck
branch
4 times, most recently
from
d974282 to
72c5f5a
Compare
updated golang.org/x/net and other related dependencies This will fix the govulncheck CI and also resolves the security issue https://pkg.go.dev/vuln/GO-2024-2687 Signed-off-by: parth-gr <[email protected]>
| go-version: "1.21.5" | ||
| go-version: "1.21.9" |
There was a problem hiding this comment.
It's nice that we can update the z-version from .5 to .9 and don't have to change the .21 y-version.
We could potentially fix future changes also by using go-version: "1.21" here without the z-version . We did a similar thing recently in Rook upstream here: https://github.com/rook/rook/pull/14175/files
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@parth-gr: This pull request references Bugzilla bug 2281619, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@travisn ready to merge, we do got the QA ACKs |
|
/bugzilla refresh |
|
@travisn: This pull request references Bugzilla bug 2281619, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@travisn we got the required acks |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-high
|
@travisn: This pull request references Bugzilla bug 2281619, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@parth-gr: All pull requests linked via external trackers have merged: Bugzilla bug 2281619 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
updated golang.org/x/net and other related
dependencies
This will fix the govulncheck CI
and also resolves the security issue
https://pkg.go.dev/vuln/GO-2024-2687
Checklist: