Syncing latest changes from upstream master for rook #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a `settings` option in the `Module` struct which can help users to futher customize the `balancer` module with a differet mode. Signed-off-by: sp98 <[email protected]>
This reduces the safe-to-remove retry interval from 1m to 15s. Closes rook#14247 Signed-off-by: Brian Dowling <[email protected]>
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks), various timeouts, and mons failing/timing out. Upstream containerd already removed the setting. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release. Signed-off-by: Onur Cakmak <[email protected]>
Currently we allow upgrade of other OSDs while migration of OSD, due to change in backing store, is pending. This will not work if the updated OSD ceph version does not support the currently applied backing store. So rook will skip any OSD upgrade if the OSD migration is pending. Signed-off-by: sp98 <[email protected]>
…eout osd: reduce safe-to-destroy retry timeout to 15s
docs: Add a note for NixOS and containerd
osd: skip upgrade if migration is pending
mgr: setting balancer mode from cluster spec.
…-master Signed-off-by: Ceph Jenkins <[email protected]>
add generated csv changes Signed-off-by: Ceph Jenkins <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch