Syncing latest changes from upstream master for rook #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the device class swallowed any error if updated for the pool. The error was not even logged, so we couldn't troubleshoot why the new crush rule was not applied. Log the error for troubleshooting and also fail the pool reconcile since the desired configuration was not applied. Signed-off-by: Travis Nielsen <[email protected]>
In order to help users check that they have implemented the newly-added Multus host configuration prerequisites, add a check to the validation tool to verify connectivity. Because users who are already running clusters with Multus enabled, add a flag that allows users to only check for host configuration prerequisites. This mode will not start the large number of clients that would normally be started because those clients could disrupt a running Rook cluster negatively. Host checking pods require host network access. Many Kubernetes distributions have pod security features enabled. In order to allow non-Vanilla distros to run this tool, allow specifying a service account that pods will run as, which can be configured by the admin to allow test pods. Signed-off-by: Blaine Gardner <[email protected]>
…dd-host-checking multus: add host checking to validation tool
Reset the Multus validation tool debounce time to its intended 30 second value. It was changed to 5 for testing, and the change was accidentally committed. Signed-off-by: Blaine Gardner <[email protected]>
multus: reset validation tool debounce time to 30
multus: reset validation tool debounce time to 30
…dependencies-fc54c511fc build(deps): bump the github-dependencies group across 1 directory with 4 updates
Use the same logrotate flow of rbd, as merged in rook#14305 1) Make the csi cephfs and nfs container logs persisted in a file 2) Use the cephcluster api specs to configure the log rotate 3) Add log rotation to rotate the log file and Add a sidecar log collector container And some fixes on the implementation: 1) Add a operator namespace in the log file path 2) Only add volume to the container if logrotate is enabled Closes: rook#12809, rook#14429 Signed-off-by: parth-gr <[email protected]>
csi: add log rotation for csi cephfs nfs pod containers
pool: Return error if device class update fails
subhamkrai
approved these changes
Jul 15, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch