Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2319878: pool: Add option to enableCrushUpdates to pool if required #768

Conversation

travisn
Copy link

@travisn travisn commented Oct 29, 2024

Add option to allow disabling the pool crush rule updates. Updates will be disabled by default but in scenarios where the user want to update failureDomain, DeviceClass etc, this option can be enabled by OCS operator, even when data rebalancing is acceptable.

Issue resolved by this Pull Request:
Resolves #https://bugzilla.redhat.com/show_bug.cgi?id=2319878

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 29, 2024
Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 29, 2024

@travisn: This pull request references Bugzilla bug 2319878, which is invalid:

  • expected the bug to target the "ODF 4.16.3" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2319878: pool: Add option to enableCrushUpdates to pool if required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@travisn travisn force-pushed the backport-disable-crush-update branch from 48e3301 to 61009d7 Compare October 29, 2024 20:12
fixing 'secert' to `secret` and adding workds like
`NotIn, addin` to skip work list.

Signed-off-by: subhamkrai <[email protected]>
(cherry picked from commit 85c25bb)
this commit upgrade the minikube, k8s, crictl versions
in CI and also fix permission error in the github runner.

Signed-off-by: subhamkrai <[email protected]>
(cherry picked from commit f647444)
@travisn travisn force-pushed the backport-disable-crush-update branch from 61009d7 to 42fe9aa Compare October 29, 2024 20:21
NymanRobin and others added 3 commits October 29, 2024 17:17
Afte pylint was updated to version 3.2.0
a set of new errors appeared. This makes
ci passing by either fixing the problem
or ignoring it in the check

Signed-off-by: NymanRobin <[email protected]>
(cherry picked from commit dcec080)
(cherry picked from commit e7e3a9c)
this will be disabled by default but in scenarios where the user want to
update failureDomain, DeviceClass etc, this option can be enabled, to be
noted this can lead to lot of data rebalancing and remapping. Use with
caution

Signed-off-by: Deepika Upadhyay <[email protected]>
(cherry picked from commit d71f9c2)
The snyk security check started failing with a warning
about the package being outdated:
github.com/libopenstorage/secrets/azure which depends on
github.com/Azure/azure-sdk-for-go/sdk/azidentity.
These and related packages are now updated.

Signed-off-by: Travis Nielsen <[email protected]>
@travisn travisn force-pushed the backport-disable-crush-update branch from 42fe9aa to 714f4a4 Compare October 29, 2024 23:21
@travisn travisn closed this Nov 6, 2024
@travisn travisn deleted the backport-disable-crush-update branch November 6, 2024 21:15
Copy link

openshift-ci bot commented Nov 6, 2024

@travisn: An error was encountered removing this pull request from the external tracker bugs for bug 2319878 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 401 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2319878: pool: Add option to enableCrushUpdates to pool if required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants