Manual sync of upstream to downstream master #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoposite workflow can't use `github` variable. close: rook#14898 Signed-off-by: Satoru Takeuchi <[email protected]>
This addresses a suggestion from a review comment in another PR. The goal of this change is to make generating make targets more systematic. Firstly, generating targets are made available under a more systematic naming following the pattern of "gen.foo". more concretely, the following targets are introduced as aliases of the corresponding existing targets: * gen.codegen * gen.rbac * gen.crds * gen.docs * gen.crd-docs additionally, a new "generate" make target is added that invokes all generating targets. Co-authored-by: Blaine Gardner <[email protected]> Signed-off-by: Michael Adam <[email protected]>
Make generating make targets more systematic
…-again test: make debug-ci label work again
The version checks for the csi driver are removed now since they are all obsolete. The K8s version and cephcsi versions are no longer checked. Anyway, the move to the csi operator would take ownership of version checks needed in the future, so for now we simplify rook deployment of the csi driver. Signed-off-by: Travis Nielsen <[email protected]>
In Rook v1.6 some new properties were added for ceph object store users, so the CI was skipping validation of that setting in the upgrade test. Now we are far past the need for that flag, and we can assume the latest flags exist for the tests. Signed-off-by: Travis Nielsen <[email protected]>
tmate session is always enabled by mistake. This bug is introduced in the following PR. rook#14934 We should enable this if `inputs.debug-ci` is `true`. Signed-off-by: Satoru Takeuchi <[email protected]>
csi: Remove version check for k8s and cephcsi
…g-tmate-session doc: avoid always enabling tmate session
For nodes that are explicitly requested for deploying OSDs, they will be skipped temporarily if not schedulable or not ready. A future reconcile is expected to schedule them. Allow the OSDs to be scheduled even on these nodes that are temporarily down, even if it blocks the reconcile from completing. Signed-off-by: Travis Nielsen <[email protected]>
If the cmd-reporter key is set under the resources element in the CephCluster CR, the memory and cpu request and limits will be set on the ceph detect version job and network job accordingly. Signed-off-by: Travis Nielsen <[email protected]>
If there are multiple clusters, `dataDirHostPath` must be unique for each cluster. However, it's not documented yet. In addition, `ceph-teardown.md` was also updated because the original document assumes that `dataDirHostPath` is `/var/lib/rook` and the files for a cluster `rook-ceph` is under `/var/lib/rook/rook-ceph`. related issue: rook#14790 Signed-off-by: Satoru Takeuchi <[email protected]>
…to-account-for-datadirhostpath doc: clarify dataDirHostPath must be unique for each cluster
test: Remove obsolete object user test flag
The upgrade of the mds daemons pauses to wait for the stopping of standby daemons before the filesystem upgrade is completed. If there are multiple filesystems, there could be standbys for other filesystems that will not be stopped at the time of the upgrade of another filesystem. Thus, the standbys may not upgrade and be stuck on the previous version. Now, the standby upgrade will only wait for standbys for the same filesystem. Signed-off-by: Travis Nielsen <[email protected]>
osd: Allow scheduling on unschedulable nodes
core: Set resources on the detect version job
mds: Wait for mds standby upgrade for same fs
The devel images have been fairly stable for Rook to test against, but on occasion there are regressions from Ceph development that affect the Rook CI. For stability during Rook development, use the latest stable version of ceph for PRs, master, and release tests. The daily CI will still use the devel images from Ceph. Signed-off-by: Travis Nielsen <[email protected]>
ci: Default to the latest stable squid instead of devel
enable monitoring for rados namespace Signed-off-by: parth-gr <[email protected]>
Signed-off-by: Artem Torubarov <[email protected]>
Resolves CIS benchmark 5.2.8 rule by adding capabilities with explicitly defined empty "add" list (where it needed) and with NET_RAW capability in "drop" list. 5.2.8 Minimize the admission of containers with added capabilities Containers must drop the `NET_RAW` capability and are not permitted to add back any capabilities. Signed-off-by: Peter Razumovsky <[email protected]>
This PR fixes an issue where disabling enableRBDStats in CephBlockPool did not remove the pool from rbd_stats_pools, leading to unnecessary monitoring. The update ensures that when enableRBDStats is set to false, the pool is properly removed from rbd_stats_pools, optimizing resource tracking. Signed-off-by: Oded Viner <[email protected]>
rbd: enable periodic monitoring for rados namespace mirroring
rgw: keep default-placement in zone config
rbd: CephBlockPool enableRBDStats not clearing rbd_stats_pools
core: add capabilities to securityContext to fix CIS 5.2.8
csiaddons required new RBAC in the next release to create/update the csiaddonsnode object based on the owner deployment/daemonset names of the pods its running with. Signed-off-by: Madhu Rajanna <[email protected]>
csi: add new RBAC required for csiaddons
Signed-off-by: Nikhil-Ladha <[email protected]>
add generated csv, crds changes Signed-off-by: Nikhil-Ladha <[email protected]>
|
/assign @travisn @subhamkrai |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nikhil-Ladha, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual sync of upstream to downstream master