Syncing latest changes from upstream master for rook #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If host path keyring file exists and created during osd-prepare but not imported to ceph auth then rook-ceph-osd activate init container will create new keyring in ceph auth by ceph auth get-or-create command. To avoid keyrings difference in host path and in ceph auth, consider importing key from host path keyring file if no keyring found in ceph auth. Resolves: rook#14825 Signed-off-by: Peter Razumovsky <[email protected]>
Remove unnecessary if-else statement inside "if keyring file exists" condition of osd activate script. Resolves: rook#14825 Signed-off-by: Peter Razumovsky <[email protected]>
Add test to canary-integration-test scenarios which removes osd auth and then recovers it on osd activation from keyring file. Resolves: rook#14825 Signed-off-by: Peter Razumovsky <[email protected]>
update the incstruction for where to run python script Signed-off-by: parth-gr <[email protected]>
external: fix external cluster docs
osd: import keyring file on activate to ceph auth if not imported yet
df-build-team
force-pushed
the
sync_us--master
branch
from
bc9fadf to
9bad30d
Compare
subhamkrai
approved these changes
Nov 18, 2024
subhamkrai
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch