Syncing latest changes from upstream master for rook #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run the tools pod with the rook-ceph-default service account setting the service account for the pod prevents SCC violations on openshift Signed-off-by: amrut-asm <[email protected]>
Bumps [dcarbone/install-jq-action](https://github.com/dcarbone/install-jq-action) from 2.1.0 to 3.0.1. - [Release notes](https://github.com/dcarbone/install-jq-action/releases) - [Commits](dcarbone/install-jq-action@8867ddb...e397bd8) --- updated-dependencies: - dependency-name: dcarbone/install-jq-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 17.0.0 to 18.0.0. - [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@db43aef...eb5ca3a) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
helm: set service account for toolbox pod
…rbone/install-jq-action-3.0.1 build(deps): bump dcarbone/install-jq-action from 2.1.0 to 3.0.1
…idAnson/markdownlint-cli2-action-18.0.0 build(deps): bump DavidAnson/markdownlint-cli2-action from 17.0.0 to 18.0.0
When node topology labels with duplicate values are detected, rook silently discards all but one label. This adds a warning informing administrators of this, allowing for easier identification of labeling issues. Signed-off-by: Fred Heinecke <[email protected]>
rook: add warning when duplicate node topology values are detected
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch