-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-942: csi: provide delete access to csiaddonsnode #787
Conversation
csiaddons sidecar needs the delete RBAC to set the ownerRef on the csiaddonsnode object. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit b34c0b9)
ran `make gen-csv` for downstream csv changes Signed-off-by: parth-gr <[email protected]>
@parth-gr: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@parth-gr: GitHub didn't allow me to assign the following users: Madhu-1. Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@parth-gr: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Madhu-1: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Madhu-1, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@parth-gr: [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
csiaddons sidecar needs the delete RBAC
to set the ownerRef on the csiaddonsnode
object.
Checklist: