Syncing latest changes from upstream master for rook #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were adding the device class as the disk rotational type, but device class can be user defined, so if user has added the device class, use that value Signed-off-by: parth-gr <[email protected]>
This includes and is based on the changes of: rook#14894 Co-authored-by: Blaine Gardner <[email protected]> Co-authored-by: subhamkrai <[email protected]> Signed-off-by: Michael Adam <[email protected]> Fixes: rook#14894
currently device class and device type labels were clubbed with eachother create a seperate label, as these two labels can be seperate Signed-off-by: parth-gr <[email protected]>
GetOSDResources method was populating wrong device class to get the osd resources This fix will fix the deviceClass label for the GetOSDResources function Signed-off-by: parth-gr <[email protected]>
build: Update codegen
the codegen ci workflow was previously fixed by copying the checkout dir to the GOPATH. With the updated codegen tooling, this alignment is not a requirement any more. This simplifies the codegen workflow again by reverting the earlier changes that added the copy mechanism. This reverts commit 714f80a. This reverts commit f32d3df. Signed-off-by: Michael Adam <[email protected]>
osd: fix device class label on osd pod
Migrate OSDs to enable encryption as day-2 operation. Signed-off-by: Santosh Pillai <[email protected]>
migrate OSDs to enable encryption as day-2 operation
ci: simplify the codegen workflow a bit
df-build-team
force-pushed
the
sync_us--master
branch
2 times, most recently
from
6fe4958 to
eabb6af
Compare
added 2 commits
December 9, 2024 03:04
…-master Signed-off-by: Ceph Jenkins <[email protected]>
add generated csv changes Signed-off-by: Ceph Jenkins <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
eabb6af to
9881941
Compare
subhamkrai
approved these changes
Dec 9, 2024
subhamkrai
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch