Syncing latest changes from upstream master for rook #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a design for CephObjectStore to allow users to pass through Ceph configs (e.g., `rgw_enable_apis`, `debug_rgw`) to the object store. This design will help users set configs that they want for their environments that aren't covered under Rook's umbrella of managed configs. This will benefit users by allowing them to make use of rare RGW features that Rook devs don't have ability to prioritize, as well as newly-released RGW features that Rook devs haven't had time to plan API interfaces for. This frees up Rook developers to focus effort on implementing APIs that have integration benefits with Kubernetes or other resources and less effort on simple configs. Signed-off-by: Blaine Gardner <[email protected]>
The default value for protocols.swift.urlPrefix is "swift", which makes the Swift API available at http://host:port/swift/v1. However, in the documentation our example says "/swift", which resulted in the unexpected endpoint http://host:port//swift/v1. Apparently, Ceph distinguishes between both values even though their docs[1] seem to suggest that using leading slashes is fine. This commit fixes the examples in the documentation to use the default value "swift". [1] https://docs.ceph.com/en/reef/radosgw/config-ref/#confval-rgw_swift_url_prefix Fixes rook#15065 Signed-off-by: Silvio Ankermann <[email protected]>
Fix the issue when using with external ceph cluster, ceph exporter secret isn't created which cause ceph-exporter fail to run. By default this option is false means ceph-exporter will run for external cluster. monitoring metricsDisabled: false This patch also adds metricsDisabled option to helm values.yaml. fixes rook#14275 Signed-off-by: Yaguang Tang <[email protected]>
The ci was using a pretty old version og golangci-lint. This updates to the latest version. Additionally, it silences some gosec integer conversion overflow false positves and fixes some real errors of this category and string format errors found by golangci-lint, while at it. Co-authored-by: Blaine Gardner <[email protected]> Co-authored-by: Travis Nielsen <[email protected]> Signed-off-by: Michael Adam <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.6 to 3.27.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@aa57810...df409f7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 6.1.2 to 6.2.0. - [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md) - [Commits](wagoid/commitlint-github-action@3d28780...0184f5a) --- updated-dependencies: - dependency-name: wagoid/commitlint-github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This change refactors inline roundup code to a function roundup_size_MiB that takes a size(in bytes) as argument and returns the smallest number of Mibibytes larger than or equal to the given size. Signed-off-by: Michael Adam <[email protected]>
ci: update golangci-lint to the latest version (v1.62)
docs: Fix misleading example for urlPrefix
…eate-issue external: fix exporter secret isn't created with external cluster
Signed-off-by: Michael Adam <[email protected]>
With the updated dependencies, the csi unit tests require new default fields in the comparison of the json test blob. Signed-off-by: Travis Nielsen <[email protected]>
build: Update api gomod dependencies
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@0025e74...ae94020) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@41dfa10...3041bf5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…tions doc: design ceph config passthru for object store
Implement rook#15119 Allow users to override RGW configurations by specifying Ceph config options in the CephObjectStore. For configurations that require RGW to be restarted when the config is applied, allow configs to be specified as CLI arguments to the RGW as well. This is an advanced option and is documented as such. Users should be careful to understand the values they are setting, as there is no validation to prevent the object store from breaking when these configs are used. Signed-off-by: Blaine Gardner <[email protected]>
…-passthru object: allow overriding rgw configs and flags
Add a sample to the CephObjectStore Advanced configuration section which shows how the new `rgwConfig` option can be used with the `additionalVolumeMounts` setting. Signed-off-by: Blaine Gardner <[email protected]>
…m/kind-action-1.11.0 build(deps): bump helm/kind-action from 1.10.0 to 1.11.0
…ions/setup-go-5.2.0 build(deps): bump actions/setup-go from 5.1.0 to 5.2.0
…hub/codeql-action-3.27.9 build(deps): bump github/codeql-action from 3.27.6 to 3.27.9
…oid/commitlint-github-action-6.2.0 build(deps): bump wagoid/commitlint-github-action from 6.1.2 to 6.2.0
update CephObjecStore examples to set bulk=true for data pools by default Signed-off-by: Artem Torubarov <[email protected]>
|
/test unit |
The docker.io/rook/ceph image contains vulnerabilities in the s5cmd binary. A new version of s5cmd was released on 16th December which resolves these issues. Signed-off-by: TomHellier <[email protected]>
rgw: bulk data pool by default
ceph: Update s5cmd to resolve vulnerabilities
the rgw operations for s3 can now be accessible using sidecar rgw-ops-log availabe in json form that can be further filtered logging for observability, this will set the rgw_enable_ops_log setting Signed-off-by: Deepika Upadhyay <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
2 times, most recently
from
b6d1860 to
95eb627
Compare
updating the groupsnapshot to betav1 api. Signed-off-by: Madhu Rajanna <[email protected]>
With new version of external snapshotter we dont need extra RBAC permission to create the volumesnapshot and volumesnapshotcontent Signed-off-by: Madhu Rajanna <[email protected]>
updating the VGS document to match the betav1 API. Signed-off-by: Madhu Rajanna <[email protected]>
…regate csi: update groupsnapshot container arg
…dependencies-9b9fa8c1e6 build(deps): bump the github-dependencies group with 3 updates
fixes the high severity DOS vulnerability mentioned in https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXNETHTML-8535262 Signed-off-by: Santosh Pillai <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
95eb627 to
9697f22
Compare
ci: update golang.org/x/net to 0.33
df-build-team
force-pushed
the
sync_us--master
branch
6 times, most recently
from
b7f224a to
2ac3fc3
Compare
If store type is empty in the cephCluster spec, use bluestore Signed-off-by: Santosh Pillai <[email protected]>
Cleanup obsolete code where the context no longer needs to be passed as a parameter to determine the namespaces to watch. Signed-off-by: Travis Nielsen <[email protected]>
When the cluster is in a different namespace from the rook operator, the csi provider name was setting the incorrect namespace prefix. Now the prefix will be the same as the ceph cluster namespace. Signed-off-by: Travis Nielsen <[email protected]>
osd: use bluestore if store type is empty
csi: Set correct driver name with csi operator
…-master Signed-off-by: DF Build Team <[email protected]>
add generated csv changes Signed-off-by: DF Build Team <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
2ac3fc3 to
53b224d
Compare
subhamkrai
approved these changes
Jan 9, 2025
subhamkrai
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch