-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-979: Revert "csi: disable fencing in Rook" #797
DFBUGS-979: Revert "csi: disable fencing in Rook" #797
Conversation
This reverts commit 4e761bd.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sp98 PTAL we need to revert the fix and move to next patch release as previous patch release was cve only |
@subhamkrai Why are you enabling it again? Please add more details about this. Also, the CI is failing. |
CI failure is kind of not related, CI is failing at the cluster creation stage which is due to the old version. We are reverting the changes as it merged in CVE only patch |
@subhamkrai is there a bug for this? please do add |
@agarwal-mudit bug is to disable the networkFence but since the changes were merged in CVE only patch we need to revert the change for now and fix in right version. So, technically no bug for this PR as it is reverting the changes only |
We need a bug for every change in z-stream (unless its test only change), please create one and reach out to Sunil/Karthick for approvals |
okay 👍🏽 |
@subhamkrai: This pull request references [Jira Issue DFBUGS-1208](https://issues.redhat.com//browse/DFBUGS-1208), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@subhamkrai: This pull request references [Jira Issue DFBUGS-1208](https://issues.redhat.com//browse/DFBUGS-1208), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@subhamkrai: This pull request references [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@sp98: This pull request references [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@sunilheggodu: This pull request references [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979), which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@subhamkrai: [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This reverts commit 4e761bd.
Checklist: