Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-979: Revert "csi: disable fencing in Rook" #797

Merged

Conversation

subhamkrai
Copy link

This reverts commit 4e761bd.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@subhamkrai
Copy link
Author

@sp98 PTAL we need to revert the fix and move to next patch release as previous patch release was cve only

@sp98
Copy link

sp98 commented Dec 19, 2024

@sp98 PTAL we need to revert the fix and move to next patch release as previous patch release was cve only

@subhamkrai Why are you enabling it again? Please add more details about this. Also, the CI is failing.

@subhamkrai
Copy link
Author

@sp98 PTAL we need to revert the fix and move to next patch release as previous patch release was cve only

@subhamkrai Why are you enabling it again? Please add more details about this. Also, the CI is failing.

CI failure is kind of not related, CI is failing at the cluster creation stage which is due to the old version.

We are reverting the changes as it merged in CVE only patch

@agarwal-mudit
Copy link
Member

@subhamkrai is there a bug for this? please do add

@subhamkrai
Copy link
Author

@subhamkrai is there a bug for this? please do add

@agarwal-mudit bug is to disable the networkFence but since the changes were merged in CVE only patch we need to revert the change for now and fix in right version. So, technically no bug for this PR as it is reverting the changes only

@agarwal-mudit
Copy link
Member

We need a bug for every change in z-stream (unless its test only change), please create one and reach out to Sunil/Karthick for approvals

@subhamkrai
Copy link
Author

We need a bug for every change in z-stream (unless its test only change), please create one and reach out to Sunil/Karthick for approvals

okay 👍🏽

@subhamkrai subhamkrai changed the title Revert "csi: disable fencing in Rook" DFBUGS-1208: Revert "csi: disable fencing in Rook" Dec 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-1208](https://issues.redhat.com//browse/DFBUGS-1208), which is invalid:

  • expected the bug to target the "odf-4.15.9" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This reverts commit 4e761bd.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@subhamkrai
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-1208](https://issues.redhat.com//browse/DFBUGS-1208), which is invalid:

  • expected the bug to target the "odf-4.15.9" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sp98 sp98 changed the title DFBUGS-1208: Revert "csi: disable fencing in Rook" DFBUGS-979: Revert "csi: disable fencing in Rook" Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This reverts commit 4e761bd.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sp98
Copy link

sp98 commented Dec 19, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@sp98: This pull request references [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sunilheggodu
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@sunilheggodu: This pull request references [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.15.9) matches configured target version for branch (odf-4.15.9)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sp98 sp98 merged commit c727ad2 into red-hat-storage:release-4.15 Dec 19, 2024
14 of 48 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@subhamkrai: [Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-979](https://issues.redhat.com//browse/DFBUGS-979) has been moved to the MODIFIED state.

In response to this:

This reverts commit 4e761bd.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug jira/valid-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants